Skip to content

Remove redundant events in favor of subscriber pattern#95

Merged
spaansba merged 2 commits into
mainfrom
update-events
May 19, 2026
Merged

Remove redundant events in favor of subscriber pattern#95
spaansba merged 2 commits into
mainfrom
update-events

Conversation

@spaansba
Copy link
Copy Markdown
Owner

  • Removed elementDataUpdated, elementOptionsUpdated, and elementReactivated events from the entire codebase
  • Added subscribeToElement() public API to ForesightManager as a lightweight alternative
  • Migrated devtools (element-tab, element-overlays) from event listeners to per-element subscriptions with debounced updates
  • Kept callbackInvoked, callbackCompleted, elementRegistered, elementUnregistered, mouseTrajectoryUpdate, scrollTrajectoryUpdate, managerSettingsChanged, and deviceStrategyChanged events
  • Updated docs, devpage-react, devpage-vue, and README to remove references to deleted events
  • Updated tests to use direct state assertions instead of event listener spies

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying foresightjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c754fdd
Status: ✅  Deploy successful!
Preview URL: https://49028e8c.foresightjs.pages.dev
Branch Preview URL: https://update-events.foresightjs.pages.dev

View logs

@spaansba spaansba merged commit dca5ad2 into main May 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant