This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Add from_folder so users can convert generic folder full of pngs to RSI#8
Open
nuke-haus wants to merge 2 commits into
Open
Add from_folder so users can convert generic folder full of pngs to RSI#8nuke-haus wants to merge 2 commits into
nuke-haus wants to merge 2 commits into
Conversation
PJB3005
suggested changes
Aug 16, 2020
PJB3005
left a comment
Member
There was a problem hiding this comment.
This method is too specific to the one action in the RSI editor, IMO. It doesn't do any "proper" handling of images with directions/animations so I don't feel like this is a good method to have here.
Author
|
Yeah i agree that it needs to handle directions/animations but in order for that to work you'd need some sort of naming scheme that people would need to know about. One possible way of doing it: Animated sprites are like thing_01.png, thing_02.png, and so-on. And if directional animations are doable then you'd combine the naming so it's thing_N_01, thing_N_02, etc. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Let me know if i missed something, i'm not a big python user