SpriteSystem helpers to retrieve LayerMap keys#6635
Open
MLGTASTICa wants to merge 4 commits into
Open
Conversation
PJB3005
requested changes
Jun 18, 2026
| return sprite.Comp.LayerMap[key]; | ||
| } | ||
|
|
||
| public bool LayerMapKeys(Entity<SpriteComponent?> sprite, [NotNullWhen(true)] out List<Object>? keys) |
Member
There was a problem hiding this comment.
It seems quite burdersome to have this method possibly fallible. Just return the list directly?
Also, does this need to return a list instead of just an array?
Contributor
Author
There was a problem hiding this comment.
Updated it , was following the model of the other functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helper to retrieve a SpriteComp's layerMap keys. Usefull for systems working with dynamic mappings