Skip to content

MSVC compiler wrapper package#321

Open
johnwparent wants to merge 81 commits into
spack:developfrom
johnwparent:win-compiler-wrapper-package
Open

MSVC compiler wrapper package#321
johnwparent wants to merge 81 commits into
spack:developfrom
johnwparent:win-compiler-wrapper-package

Conversation

@johnwparent
Copy link
Copy Markdown
Contributor

@johnwparent johnwparent commented Jun 19, 2025

Updates the compiler wrapper package to handle
Windows compiler wrappers

Adds builders for the new compiler wrapper flavor

Adds proper env setup for the wrapper

Updates the MSVC package for compiler wrapper
support

Sibling to spack/spack#38495

@johnwparent johnwparent marked this pull request as draft June 19, 2025 21:30
@johnwparent
Copy link
Copy Markdown
Contributor Author

johnwparent commented Jun 19, 2025

cc @scheibelp

@johnwparent johnwparent force-pushed the win-compiler-wrapper-package branch from 70c8e00 to a57db71 Compare August 26, 2025 21:03
@github-actions github-actions Bot added new-version dependencies patch update-package ci Issues related to Continuous Integration labels Aug 26, 2025
@johnwparent johnwparent force-pushed the win-compiler-wrapper-package branch from a57db71 to 6f7f3c0 Compare August 26, 2025 21:45
@github-actions github-actions Bot removed the ci Issues related to Continuous Integration label Aug 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 25, 2026

This pull request has been automatically marked as stale because it has not had any activity in the last 6 months. It will be closed in 30 days if there is no further activity.
If the pull request is waiting for a reply from reviewers, feel free to ping them as a reminder. If it is waiting and has no assigned reviewer, feel free to ping @spack/spack-releasers or simply leave a comment saying this should not be marked stale. This will reset the pull request's stale state.
To get more eyes on your pull request, you can post a link in the #pull-requests channel of the Spack Slack.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label Feb 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2026

This pull request was closed because it had no activity for 30 days after being marked stale. If you feel this is in error, please feel free to reopen this pull request.

@github-actions github-actions Bot closed this Mar 27, 2026
@johnwparent johnwparent reopened this Apr 30, 2026
@github-actions github-actions Bot removed the stale label May 1, 2026
@johnwparent johnwparent force-pushed the win-compiler-wrapper-package branch from a5651e1 to 65d8654 Compare May 4, 2026 20:23
@spackbot-triage spackbot-triage Bot removed the patch label May 4, 2026
@johnwparent johnwparent marked this pull request as ready for review May 5, 2026 18:25
@johnwparent johnwparent force-pushed the win-compiler-wrapper-package branch from aa58caa to d23af75 Compare May 5, 2026 18:41
@spackbot-triage spackbot-triage Bot requested a review from haampie May 5, 2026 18:42
@johnwparent johnwparent requested a review from a team as a code owner May 5, 2026 21:18
@johnwparent
Copy link
Copy Markdown
Contributor Author

johnwparent commented May 8, 2026

@kwryankrattiger sorry for the ping, feel free to review if you want, but I'm just messing with the stacks to debug, all the stack changes will be reverted before merge

@johnwparent
Copy link
Copy Markdown
Contributor Author

johnwparent commented May 11, 2026

Trying a "no cache" run to see if that's the cause of our issues

@johnwparent
Copy link
Copy Markdown
Contributor Author

johnwparent commented May 11, 2026

@spackbot rebuild everything

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented May 11, 2026

I've started that pipeline for you!

@spackbot-triage spackbot-triage Bot added the ci Issues related to Continuous Integration label May 11, 2026
johnwparent added 15 commits May 29, 2026 16:51
@johnwparent
try 1.0?
fee6e75 
Not sure 0.1.0 is coming from

Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
Bump core spack sha to capture bootstrap wrapper spec version update
56946c2 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
support paths with spaces
0461734 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
quick rebase
3e15c69 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
quote prefix
1af0804 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
Try to fix install from nmake side
f5531e7 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump core again
b8f6c32 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
boneheaded upstream bug fix commit bump
6f592a0 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
Version bump for better upstream path with space support
d14f3d3 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
real vis stack
720657e 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
No solve, artifact too large
ce44368 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump spack sha to grab logger changes
8cad3d6 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
no depends on c for win gpg
bc4eda7 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump wrapper and sha
85962e7 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
another wrapper bump
50a5fbd 
Fixes python

Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent johnwparent force-pushed the win-compiler-wrapper-package branch from 6772a0c to 50a5fbd Compare May 29, 2026 20:51
johnwparent added 14 commits May 31, 2026 18:30
@johnwparent
New core change requirement
5bf1c8e 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
Make msvc a run dep
6093eee 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump spack sha
6347fbb 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump compiler wrapper
2ce0753 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump wrapper
3758588 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
Add run context for msvc and use properly in spack core
2258e3c 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump wrapper to restore dumpbin usage
a1dc8f5 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
style
0fe3db9 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
quote ifort invocation
7645f94 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
proper quotes
c1b2b40 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
debug the wrapper
40a314d 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
Support lctg binaries
4b3c5c3 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
wrapper bump - coff verify write access permissions
a34824b 
Signed-off-by: John Parent <john.parent@kitware.com>
@johnwparent
bump core for more wrapper debugging
072a3f4 
Signed-off-by: John Parent <john.parent@kitware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haampie haampie Awaiting requested review from haampie

@kwryankrattiger kwryankrattiger Awaiting requested review from kwryankrattiger kwryankrattiger is a code owner

@scheibelp scheibelp Awaiting requested review from scheibelp

@zackgalbreath zackgalbreath Awaiting requested review from zackgalbreath zackgalbreath is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci Issues related to Continuous Integration dependencies new-version update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnwparent @haampie