Skip to content

py-openai: remove from e4s-oneapi test list#3868

Closed
yizeyi18 wants to merge 1 commit into
spack:developfrom
yizeyi18:openai-ci
Closed

py-openai: remove from e4s-oneapi test list#3868
yizeyi18 wants to merge 1 commit into
spack:developfrom
yizeyi18:openai-ci

Conversation

@yizeyi18
Copy link
Copy Markdown
Contributor

py-openai depends on py-jiter in recent versions, which introduces a py-maturin dependent. For e4s-oneapi ci array fails to build py-maturin, this PR removes py-openai from this array.

@yizeyi18 yizeyi18 requested a review from eugeneswalker as a code owner March 17, 2026 12:48
@yizeyi18
Copy link
Copy Markdown
Contributor Author

As the failed ci pipeline windows-vis-generate is non-related to this PR, some earlier PRs also fail on it and some later not, I call for a re-run pipeline here.

@spackbot re-run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Mar 18, 2026

I've started that pipeline for you!

@yizeyi18
Copy link
Copy Markdown
Contributor Author

@spackbot help

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Mar 18, 2026

You can interact with me in many ways!

  • @spackbot hello: say hello and get a friendly response back!
  • @spackbot help or @spackbot commands: see this message
  • @spackbot run pipeline or @spackbot re-run pipeline: to request a new run of the GitLab CI pipeline
  • @spackbot rebuild everything: to run a pipeline rebuilding all specs from source.
  • @spackbot fix style if you have write and would like me to run spack style --fix for you.
  • @spackbot maintainers or @spackbot request review: to look for and assign reviewers for the pull request.

I'll also help to label your pull request and assign reviewers!
If you need help or see there might be an issue with me, open an issue here

@eugeneswalker
Copy link
Copy Markdown
Contributor

eugeneswalker commented Mar 18, 2026

I see you disabled the spec and added a comment with error annotation. But isn't this building just fine in CI right now? Otherwise develop pipelines would be failing, which they are not... Why disable it?

@yizeyi18
Copy link
Copy Markdown
Contributor Author

@eugeneswalker Because the version of py-openai currently in develop is 0.27.8 which does not depend on py-maturin. #3746 is blocked when trying to bump it to 2.26.0 .

Copy link
Copy Markdown
Contributor

@eugeneswalker eugeneswalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now. Thank you!

@yizeyi18
Copy link
Copy Markdown
Contributor Author

As py-openai has already been deleted in #3807, this PR would be closed. Thanks for Eugenes!

@yizeyi18 yizeyi18 closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants