NetCDF-c: Ensure plugin path is posix#4293
Merged
tgamblin merged 2 commits intoMay 28, 2026
Merged
Conversation
Otherwise CMake will choke on a Windows escape character if based in the C: drive Signed-off-by: John Parent <john.parent@kitware.com>
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/netcdf_c/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/netcdf_c/package.py:405: [E501] line too long (104 > 99 characters)
repos/spack_repo/builtin/packages/netcdf_c/package.py:409: [E501] line too long (115 > 99 characters)
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
I've updated the branch with style fixes. |
Contributor
Author
|
Finally was able to determine the failure cause: |
Contributor
Author
|
Let's see if we maybe just caught the nodes at a bad moment |
Contributor
Author
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
Contributor
Author
|
@climbfuji sorry for the delay, finally got a reproduction, my goal is to have both our PRs in for the upcoming packages release. |
Contributor
That's awesome, thanks! |
Contributor
Author
|
Green CI, lets get this in |
tgamblin
approved these changes
May 28, 2026
Contributor
Author
|
Thanks @tgamblin ! |
thomas-bouvier
pushed a commit
to thomas-bouvier/spack-packages
that referenced
this pull request
May 30, 2026
Otherwise CMake will choke on a Windows escape character if based in the C: drive --------- Signed-off-by: John Parent <john.parent@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise CMake will choke on a Windows escape character if based in the C: drive
Fixes some CI failures holding up other PRs on Windows