fms: add 2025.03, 2026.01, and 2026.01.01#4737
Conversation
|
@rem1776 Your PR here is "above" mine in #3210 But in mine I also have an extra variant to allow for I also seem to have: # When https://github.com/NOAA-GFDL/FMS/pull/1787 is merged, we can uncomment the following
# and allow back specified precision variants for 2026.0x and later.
# variant(
# "precision",
# values=any_combination_of("32", "64", "mixed").with_default("mixed"),
# description="Build a version of the library with mixed precision ('mixed' or 'none'), or 32 and/or 64 bit reals",
# when="@2026.0x:",
# )commented out in there. Any objections to adding in the |
|
I'm guessing 2026.01.01 might have NOAA-GFDL/FMS#1787 ? |
No objections here! I can add that in.
Yeah 2026.01.01 includes that change, which should also fix the build issue. I still included the patch just so that spack doesn't have to waste time building our unit tests. |
Updated the precision variant to support mixed precision and adjusted the default value.
|
@rem1776 I think we need all three: variant(
"precision",
values=any_combination_of("32", "64", "mixed").with_default("mixed"),
description="Build a version of the library with mixed precision ('mixed' or 'none'), or 32 and/or 64 bit reals",
when="@2026.01.01:",
)
# NOTE: For FMS 2025.04 to 2026.01, only mixed precision ('none') is supported.
# Since a single variant is no variant, we do not have a precision variant for these versions.
variant(
"precision",
values=("mixed",),
description="Build a version of the library with mixed precision (both 32 and 64 bit reals). "
"NOTE: This is the only supported precision variant for FMS versions 2025.04 to 2026.01",
default="mixed",
multi=True,
when="@2025.04:2026.01",
)
variant(
"precision",
values=("32", "64"),
description="Build a version of the library with default 32 or 64 bit reals or both",
default="32",
multi=True,
when="@2022.04:2025.03",
)The issue is that 2025.04 and 2026.01 only support |
They only worked with 'mixed' before due to a bug with cmake, but with the patches added by this PR all 3 options should now work for those two versions. |
Updates the fms package for the past 3 releases. Includes patches to disable the unit tests building by default.
Fixes #3596, NOAA-GFDL/FMS#1865,