Fix pin assignments in SerialMenus example.#11
Open
troth wants to merge 1 commit intosparkfun:masterfrom
Open
Conversation
The hardware setup comment states: INT1XM --- 3 INT2XM --- 2 But the variable initializations do not match that. Change the variable initializations to match the comments. Decided to change the inits instead of the comment have the pin ordering on the arduino match the pin ordering on the breakout board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardware setup comment states:
INT1XM --- 3
INT2XM --- 2
But the variable initializations do not match that. Change the variable
initializations to match the comments. Decided to change the inits
instead of the comment have the pin ordering on the arduino match the
pin ordering on the breakout board.