Skip to content

Handle preUpdate ahead of updating material uniforms to avoid 1 frame latency #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrxz wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −25
Open

Handle preUpdate ahead of updating material uniforms to avoid 1 frame latency #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 26 additions & 25 deletions src/SparkRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,32 @@ export class SparkRenderer extends THREE.Mesh {
const isNewFrame = frame !== spark.lastFrame;
spark.lastFrame = frame;

// Trigger update (either sync in case of preUpdate, or async through setTimeout)
if (spark.autoUpdate && isNewFrame) {
const preUpdate = spark.preUpdate && !renderer.xr.isPresenting;
const useCamera = renderer.xr.isPresenting
? renderer.xr.getCamera()
: camera;
if (preUpdate) {
spark.updateInternal({
scene,
camera: useCamera,
autoUpdate: true,
});
} else {
if (spark.updateTimeoutId === -1) {
spark.updateTimeoutId = setTimeout(() => {
spark.updateTimeoutId = -1;
spark.updateInternal({
scene,
camera: useCamera,
autoUpdate: true,
});
}, 1);
}
}
}

// Determine render target
const currentRenderTarget = renderer.getRenderTarget();
const isXRRenderTarget = checkIsXRRenderTarget(currentRenderTarget);
Expand Down Expand Up @@ -828,31 +854,6 @@ export class SparkRenderer extends THREE.Mesh {
// Alternating debug flag that can aid in visual debugging
this.uniforms.debugFlag.value = (performance.now() / 1000.0) % 2.0 < 1.0;

if (spark.autoUpdate && isNewFrame) {
const preUpdate = spark.preUpdate && !renderer.xr.isPresenting;
const useCamera = renderer.xr.isPresenting
? renderer.xr.getCamera()
: camera;
if (preUpdate) {
spark.updateInternal({
scene,
camera: useCamera,
autoUpdate: true,
});
} else {
if (spark.updateTimeoutId === -1) {
spark.updateTimeoutId = setTimeout(() => {
spark.updateTimeoutId = -1;
spark.updateInternal({
scene,
camera: useCamera,
autoUpdate: true,
});
}, 1);
}
}
}

spark.dirty = false;
}

Expand Down
Loading