Skip to content

Add missing unspecified codes#4

Open
filipe-costa wants to merge 2 commits intospatialillusions:mainfrom
filipe-costa:add-missing-unspecified-codes
Open

Add missing unspecified codes#4
filipe-costa wants to merge 2 commits intospatialillusions:mainfrom
filipe-costa:add-missing-unspecified-codes

Conversation

@filipe-costa
Copy link
Copy Markdown

I have noticed that some unspecified and not applicable codes were missing from the milstandard-e package - I have based these on the milstd2525e standard documentation.

@spatialillusions
Copy link
Copy Markdown
Owner

I removed all unspecified and not applicable symbols from the tables when I created them, since they either won't display a symbol when used with Milsymbol, or shouldn't be used in an application since, like you say are unspecified or not applicable.
Could you please describe the use case for when it is useful to have them included?

@filipe-costa
Copy link
Copy Markdown
Author

My use case is that I automatically generate form fields (dropdowns) based on these for related libraries, which otherwise, I would have to build logic specifically on top of this library, while using different logic for the 2525d/app6d, etc; other few things I can think of is:

  • Keep consistency between this and previous libraries which already contain these fields.
  • Keep it consistent with the actual defined military standard - despite of what the milsymbol library might or not do with these values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants