Fixed non-hardware-executed tests for WSE-3#63
Fixed non-hardware-executed tests for WSE-3#63jonathan-pepino-schaefer wants to merge 6 commits into
Conversation
This commit introduces several changes: - Renamed the task_recycling_*.sptl files to a wse2 specific version - Created new corresponding task_recycling_*_wse3.sptl files that represent correct test cases for wse3 - Added conditional test case execution depending on environment variable WSE_ARCH
This commit introduces several changes: - Renamed the task_recycling_*.sptl files to a wse2 specific version - Created new corresponding task_recycling_*_wse3.sptl files that represent correct test cases for wse3 - Added conditional test case execution depending on environment variable WSE_ARCH
Bugfix/fix taskid recycling wse3
tbennun
left a comment
tbennun
left a comment
There was a problem hiding this comment.
The change makes sense, thank you! The formatter you use creates a larger diff which is harder to review, please undo that and use our existing yapf style file instead.
|
|
||
| def _load_sample_kernel(): | ||
| sample = os.path.join(os.path.dirname(__file__), '..', 'csl_runtime', 'samples', 'task_recycling_merge.sptl') | ||
| kernel = f'task_recycling_merge_{os.getenv("WSE_ARCH", "wse2")}.sptl' |
There was a problem hiding this comment.
Why not use spada.syntax.csl.constants.ARCH instead?
There was a problem hiding this comment.
I forgot that this constant exists, I will change it to constants.ARCH
|
|
||
|
|
||
| def test_plan_is_deterministic(): | ||
| tasks = _create_linear_local_tasks(len(constants.LOCAL_TASK_IDS) + 5) |
There was a problem hiding this comment.
Looks like some formatter was used that is different from what we use (yapf): https://github.com/spcl/spada/blob/main/.style.yapf
This creates a larger diff than it should be here.
There was a problem hiding this comment.
In the README the required style formatter for contributing is black (which is also installed as part of the dev environment). I did not know that yapf schould be used, I will correct that!
2 participants
I mentioned in #61 some tests that fail when setting
WSE_ARCH=wse3. These tests are task-recycling related. This PR introduces a fix for the testcases such that the test setting is correct both in the wse2 and wse3 scenario.(The many small style changes come from applying
blackto the respective files, as this seems not to have happened before my PR in this file, or a different configuration was somehow used?)