Skip on existing Splocalecontaineritem instead of Splocalecontainer #7562
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by c6300f1 on branch refs/heads/issue-7559
Triggered by 5c9b0d4 on branch refs/heads/issue-7559
|
|
||
| const isLoanReturnLike = | ||
| isLoanReturn || (actionTable.name !== 'Loan' && actionTable.name.includes('Loan')); | ||
| isLoanReturn || |
Member
There was a problem hiding this comment.
Why does this PR reformat this?
grantfitzsimmons
requested changes
Jan 28, 2026
Member
grantfitzsimmons
left a comment
grantfitzsimmons
left a comment
There was a problem hiding this comment.
I have a database (shared with Alec) that is missing agent3, agent4, and agent5 in the Loan table after running ve/bin/python manage.py run_key_migration_functions. This is not handled in this PR, resulting in an incomplete schema. This fixes the missing tables and fields for 7-only tables, but not if a discipline was added after we added fields to an existing table.
github-project-automation
bot
moved this from 📋Back Log
to Dev Attention Needed
in General Tester Board
Member
Author
|
This PR will be handled in the #7672 PR |
github-project-automation
bot
moved this from Dev Attention Needed
to ✅Done
in General Tester Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7559
Skip on existing Splocalecontaineritem instead of Splocalecontainer. This works on the example workshop database. More testing to be done on other databases.
Checklist
self-explanatory (or properly documented)
Testing instructions
ve/bin/python manage.py run_key_migration_functionsDjango command runs before testing.