-
Notifications
You must be signed in to change notification settings - Fork 40
[Guided Setup + Config Tool] Complete configuration tool + default trees import + guided setup #7647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Triggered by ad19264 on branch refs/heads/issue-7593
Improve styling
* optimize tree creation * Fix duplication * Renumber tree and set full names * Lint code with ESLint and Prettier Triggered by cb60fbc on branch refs/heads/issue-7641-1
Clean up backend code for trees in setup tool
Triggered by a75062b on branch refs/heads/issue-7593
|
@grantfitzsimmons
Not sure why taxon tree configuration was still showing up, that shouldn't be there anymore. So that might be the cause of the crash during setup. For anyone that tested #7669, that PR has now been merged into this one, so those testing instructions have been added here as well. |
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this error when trying to setup a DB UnboundLocalError("cannot access local variable 'rank_data' where it is not associated with a value")
01-27_08.51.mp4
|
@emenslin Pushed a fix for the UnboundLocalError issue. Good to try it out again. I noticed that is works with a tree like Mammalogy, but got an error reading the rank data for Herpetology: Looks like it's caused by the json fields maybe not being correct or missing data? |
|
I am running to an issue similar to @acwhite211. In my case it was with Ichthyology and with the Storage Tree. I tested by leaving Storage Tree ranks as they appear when entering the form and when editing those ranks through the UI. |
|
Ran into the same error as @acwhite211 with botany and ornithology but it worked with invert zoology (unsure about others). I did not attempt any customizations with any of these setups so I am not sure if that would cause any other problems (i.e. the storage tree issue mentioned above). Additionally, upon upload of the invert zoology tree it includes all sub and super ranks even if there are no nodes in them, is this intentional? Link to DB if needed: https://blankdbsetup1elizabeth20260127-issue-7593.test.specifysystems.org/specify/tree/taxon/ |
|
After discussing this we decided that the tree default files should all have the same format, so I went ahead and simplified the file loading 👍
@kwhuber I'm not entirely sure how this happened on the Storage tree, but I updated all the tree defaults to use the same format so it should be more reliable now. I tested most disciplines and it seems to work again.
This is expected behavior for now since the rank configuration was removed (So it always uses the default configuration, which includes those ranks). |
kwhuber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Ichthyology with pre-loaded taxon tree.
Tested on Vertebrate Paleontology without pre-loaded taxon tree.
Most the of tests ran successfully! However, I ran into issue with the Geography tree (see below).
- Configure ranks for the geography.
- Test the new pre-load tree check box for geography and taxon trees.
- The pre-load checkbox for taxon trees should only be enabled if your discipline has a default tree (EX: Mammalogy has one, Geology doesn't).
- After the setup, make sure the default tree creation process started for the trees you selected to pre-load. (You will see notifications)
- If you chose not to pre-load the taxon tree, the tree that was created should not have a root node.
- After the setup, check all the new trees, make sure the ranks respect your configuration.
- Pre-loaded trees should have had full names generated. You can check the full name preview on a taxon record for example.
- Configuration tool and existing trees
- Creating a new discipline with the configuration tool should create an empty taxon tree.
- Tested with Entomology and ranks matched that discipline
- An empty taxon tree should have an import button
- Make sure you can import a taxon tree into the existing empty tree
- Completed in ~25 seconds
- Make sure you can still create a new populated tree
- Creating a new discipline with the configuration tool should create an empty taxon tree.
- Tree speedup testing (You may have already done some of these)
- Make sure the trees were pre-loaded correctly.
- Make sure the tree was created correctly. An easy way to check is to compare it with the same tree created before the speed ups.
I believe its just a loading error since all the states were moved to the same parent. Merging now but all issues will be addressed in the main PR |






Fixes #7593, #7641
Changes:
Checklist
self-explanatory (or properly documented)
Testing instructions