chore(spec-specs): EIP-8037 backports and refactors

[spencer-tb]

🗒️ Description

Companion PR to ethereum#2901 (EIP-8037), addressing the backport/refactor review comments so the forks/osaka to forks/amsterdam diff shows only genuine EIP-8037 changes.

Backports

• chore(spec-specs): move state fields to end of message call output (f04b6a4)
  • Reorders MessageCallOutput so the four EIP-8037 fields append at the bottom, giving a clean append only diff against forks/osaka (the keyword argument conversion was already backported in refactor(spec-specs): use kwargs for message call output collision returns ethereum/execution-specs#2238). Resolves review comment.
• chore(spec-specs): backport intrinsic gas cost dataclass (5f1b567)
  • Replaces the (intrinsic_gas, calldata_floor) tuple from calculate_intrinsic_cost/validate_transaction with an IntrinsicGasCost dataclass in the tuple returning forks (Prague, Osaka, BPO1 to BPO5), mirroring amsterdam minus its state field. Resolves review comment.
• chore(spec-specs): backport calculate message call gas keyword arguments (be445af)
  • Converts the call() invocation of calculate_message_call_gas from positional to keyword arguments across Tangerine Whistle to BPO5, so amsterdam's switch to keyword form reads as a value only diff. Resolves review comment.
• chore(spec-specs): add generic call params dataclass for generic call (97e342e)
  • Bundles generic_call's long positional argument list into a per fork GenericCallParams dataclass across all 24 forks. Resolves review comment.

Refactors

• chore(spec-specs): inline the sstore state gas constant (5f3144d)
  • Drops the redundant state_gas_storage_set local in sstore and uses StateGasCosts.STORAGE_SET directly (amsterdam only). Resolves review comment (and suggestion).
• chore(spec-specs): split sstore regular and state gas (ade3f44)
  • Separates sstore's state gas updates into their own if stack and lifts credit_state_gas_refund out of the nested refund branch (amsterdam only). Resolves review comment.
• chore(spec-specs): trim state gas costs docstring (3754685)
  • Moves the "patched at runtime" implementation detail out of the StateGasCosts docstring into a comment above the class (amsterdam only). Resolves review comment.

Explicitly Unchanged

Merging charge_state_gas into charge_gas? Should the two functions be folded into a single charge_gas(evm, *, regular, state)?

The decision was to keep it as 2 separate functions so each function emits its own EIP-3155 trace event GasAndRefund & StateGasAndRefund. We can reopen this question once tracing is consolidated in a follow up PR.

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  just static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

[SamWilsn]

How about just GenericCall?

[spencer-tb]

Sounds good to me! :D

[spencer-tb]

Pushed!

[SamWilsn]

Suggested change

	is_static=True if params.is_staticcall else evm.message.is_static,
	is_static=params.is_staticcall or evm.message.is_static,

[spencer-tb]

Pushed!