Add sftpfs files WriteAt and Sync methods#429
Open
MRtecno98 wants to merge 3 commits intospf13:masterfrom
Open
Add sftpfs files WriteAt and Sync methods#429MRtecno98 wants to merge 3 commits intospf13:masterfrom
MRtecno98 wants to merge 3 commits intospf13:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #378 the WriteAt and Sync methods are also missing and a TODO despite being implemented by sftp.File already.
Also may i suggest just nesting sftp.File into sftpfs.File to have all necessary interfaces implemented without delegate methods? Something like this
This would allow removing methods
Close Name Stat Sync Truncate Read ReadAt Seek Write WriteAtwhich are just simple delegates. I'll gladly implement the change if it's ok otherwise you can just merge this pr as it is.