Skip to content

Add sftpfs files WriteAt and Sync methods#429

Open
MRtecno98 wants to merge 3 commits intospf13:masterfrom
MRtecno98:feat/sftptodos
Open

Add sftpfs files WriteAt and Sync methods#429
MRtecno98 wants to merge 3 commits intospf13:masterfrom
MRtecno98:feat/sftptodos

Conversation

@MRtecno98
Copy link
Contributor

Similarly to #378 the WriteAt and Sync methods are also missing and a TODO despite being implemented by sftp.File already.

Also may i suggest just nesting sftp.File into sftpfs.File to have all necessary interfaces implemented without delegate methods? Something like this

type File struct {
        *sftp.File
	client *sftp.Client
}

This would allow removing methods Close Name Stat Sync Truncate Read ReadAt Seek Write WriteAt which are just simple delegates. I'll gladly implement the change if it's ok otherwise you can just merge this pr as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant