construct a new bytes.Reader per each opened file in tarfs#487
Open
aslilac wants to merge 3 commits intospf13:masterfrom
Open
construct a new bytes.Reader per each opened file in tarfs#487aslilac wants to merge 3 commits intospf13:masterfrom
aslilac wants to merge 3 commits intospf13:masterfrom
Conversation
|
|
aslilac
changed the title
|
@sagikazarmark are PRs being actively reviewed? |
Collaborator
|
Makes sense to me. Added to my review queue. |
|
@sagikazarmark following up on this one; do you intend to review/merge it any time soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
Currently, every call to
Open"copies" theFile, but since it has pointer fields, it's not really the kind of clean independent copy that's desired here. Notably, everyFileshares the samebytes.Readerstate.This causes a few bugs:
Closed has haddataset tonil, essentially permanently erasing that file.My proposed solution is to introduce an internal
fsEntrytype, and to construct a newtarfs.Filefrom that data on each call toOpen. Continuing to share a*tar.Headerfield seems fine, as you shouldn't modify that during normal use.