support page updates for resolved comments over skipping#1176
Merged
Conversation
Users can use `confluence_publish_skip_commented_pages` to hint to skip page updates that have comments. This also captures pages that have comments that are resolved. In order to be flexible for users who want to drop comment references for pages with resolved comments, this commit introduces the option: confluence_publish_skip_commented_pages = 'ignored-resolved' If a page with comment entries detects all comments have been resolved (or dangling), pages will not be skipped but instead updated as normally. Note that this is not a perfect solution, as a page update will still drop comment references on the page, causing all remaining comments to be dangling. Signed-off-by: James Knight <git@jdknight.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can use
confluence_publish_skip_commented_pagesto hint to skip page updates that have comments. This also captures pages that have comments that are resolved.In order to be flexible for users who want to drop comment references for pages with resolved comments, this commit introduces the option:
If a page with comment entries detects all comments have been resolved (or dangling), pages will not be skipped but instead updated as normally.
Note that this is not a perfect solution, as a page update will still drop comment references on the page, causing all remaining comments to be dangling.