Fix detection of git submodules#49
Open
djhoese wants to merge 1 commit into
Open
Conversation
Author
|
So I'm trying to make this work for my own project and it turns out this won't work when we get to the ref filtering as the |
Author
|
Ok even if I hack that to work (modifying |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
This uses the "--show-superproject-working-tree" flag in the
get_toplevel_pathcall to git to add an additional line of output if the current directory is a git submodule of another project (a super project). When provided along with the--show-toplevelflag and when in a git submodule you will get two lines of output. One for the git submodule root and one for the super project root (note: order of the flags in the command determine the order of the lines in the output). If it isn't a git submodule then there will only ever be one line of output.