Bump types-docutils and fix ty type checker errors#14328
Open
adamtheturtle wants to merge 2 commits intosphinx-doc:masterfrom
Open
Bump types-docutils and fix ty type checker errors#14328adamtheturtle wants to merge 2 commits intosphinx-doc:masterfrom
adamtheturtle wants to merge 2 commits intosphinx-doc:masterfrom
Conversation
- Update types-docutils from 0.22.3.20251115 to 0.22.3.20260223 - Fix 115 ty errors by updating renamed rule names and adding inline suppressions - Update ty.toml: rename non-subscriptable → not-subscriptable - Add ty ignore comments for false positives in Napoleon config, autosummary, C/C++ domain code, and other modules where ty can't narrow union types - Add None checks for reference node access in intersphinx ty check now passes with 0 errors while keeping mypy passing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove redundant inline comment from line 153 to bring it within the 95-character line length limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bump
types-docutilsto the latest version (0.22.3.20260223) and fix all ty type checker errors to align with the new version.The new types-docutils version added
__slots__ = ()to theVersionInfoclass. Combined with a newer ty version (0.0.18), this revealed 115 type checking errors in the Sphinx codebase that were previously undetected by older ty versions.Changes
non-subscriptable→not-subscriptable(15 errors fixed)# ty: ignore[rule]comments for 100+ false positives:Status
Resolves #14317