Fix intersphinx leaking basic auth credentials in error and info messages#14366
Open
joshuaswanson wants to merge 1 commit intosphinx-doc:masterfrom
Open
Fix intersphinx leaking basic auth credentials in error and info messages#14366joshuaswanson wants to merge 1 commit intosphinx-doc:masterfrom
joshuaswanson wants to merge 1 commit intosphinx-doc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14342.
When intersphinx fails to fetch an inventory or detects a redirect, the error and info messages include the raw URL with basic auth credentials. The
_get_safe_urlhelper already exists in this file (and is used for the initial "loading inventory" info message) but wasn't applied to the error path in_fetch_inventory_urlor the "inventory has moved" log message.