docs(cayenne): correct footer_cache_mb default in v2.1.x (50 MB when unset, not 128)#1932
Open
claudespice wants to merge 1 commit into
Open
docs(cayenne): correct footer_cache_mb default in v2.1.x (50 MB when unset, not 128)#1932claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
|
🚀 deployed to https://dcae2dc4.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
version-2.1.xCayenne accelerator page still documentscayenne_footer_cache_mbas "Defaults to128", but at v2.1.0 the field isfooter_cache_mb: Option<usize>=Nonewhen unset, and the runtime applies it to DataFusion's metadata cache only whenSome— so when unset, no explicit limit is set and DataFusion's own default file-metadata-cache limit of 50 MB applies. There is no 128 MB default in v2.1.0.This is the correction docs#1908 made for vNext and version-2.0.x, which was missed on the
version-2.1.xsnapshot (it was cut around the same time as #1908 and inherited the pre-correction "128" text). vNext and 2.0.x already read correctly; v1.10.x/v1.11.x correctly keep128(the field was a realusize = 128in those releases).What changed (version-2.1.x only, 3 spots to match vNext/2.0.x):
runtime.paramstable row forcayenne_footer_cache_mbDefault: 128 MB→Default: unset — … 50 MB applies)Footer cache | 128 MB→50 MB | Unset by default …)Source
spiceai/spiceai@v2.1.0:crates/cayenne/src/catalog_provider.rs:52—pub footer_cache_mb: Option<usize>crates/runtime/src/builder.rs:473— applied onlyif cayenne_footer_cache_mb.is_some()Test plan
cd website && npm run buildpasses