docs(duckdb): fix stale memory-limit guidance in 2.1.x accelerator guide#1936
Open
claudespice wants to merge 1 commit into
Open
docs(duckdb): fix stale memory-limit guidance in 2.1.x accelerator guide#1936claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
…ide (missed #1906 propagation)
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://7d89db86.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DuckDB accelerator deployment guide for
version-2.1.xstill told users to set memory via a channel that does not exist — "set amemory_limitpragma via the connection string" (in the Memory sizing note and the OOM on refresh troubleshooting row).PR #1906 already corrected this fabricated mechanism to the real
duckdb_memory_limitacceleration parameter, but that fix landed in vNext andversion-2.0.xonly and missed theversion-2.1.xsnapshot, leaving the just-released docs wrong. This propagates the same correction to 2.1.x so all live versions agree.Verified against code (spiceai/spiceai)
duckdb_memory_limit(crates/runtime/src/dataaccelerator/duckdb.rs,ParameterSpec::component("memory_limit")), confirmed present at thev2.1.0release tag that backsversion-2.1.x.duckdb_memory_limitis the supported knob, matching what vNext andversion-2.0.xalready document.Scope
Version-specific propagation fix — only
version-2.1.xwas stale (vNext andversion-2.0.xwere already fixed by #1906), so this touches a single file.Test plan
cd website && npm run buildpasses (prose-only change; no links/tags added)