Skip to content

docs(duckdb): fix stale memory-limit guidance in 2.1.x accelerator guide#1936

Open
claudespice wants to merge 1 commit into
trunkfrom
fix-duckdb-accel-2.1.x-memory-param
Open

docs(duckdb): fix stale memory-limit guidance in 2.1.x accelerator guide#1936
claudespice wants to merge 1 commit into
trunkfrom
fix-duckdb-accel-2.1.x-memory-param

Conversation

@claudespice

Copy link
Copy Markdown
Collaborator

Summary

The DuckDB accelerator deployment guide for version-2.1.x still told users to set memory via a channel that does not exist — "set a memory_limit pragma via the connection string" (in the Memory sizing note and the OOM on refresh troubleshooting row).

PR #1906 already corrected this fabricated mechanism to the real duckdb_memory_limit acceleration parameter, but that fix landed in vNext and version-2.0.x only and missed the version-2.1.x snapshot, leaving the just-released docs wrong. This propagates the same correction to 2.1.x so all live versions agree.

Verified against code (spiceai/spiceai)

  • The DuckDB accelerator exposes duckdb_memory_limit (crates/runtime/src/dataaccelerator/duckdb.rs, ParameterSpec::component("memory_limit")), confirmed present at the v2.1.0 release tag that backs version-2.1.x.
  • The accelerator has no connection-string / pragma configuration channel — duckdb_memory_limit is the supported knob, matching what vNext and version-2.0.x already document.

Scope

Version-specific propagation fix — only version-2.1.x was stale (vNext and version-2.0.x were already fixed by #1906), so this touches a single file.

Test plan

  • cd website && npm run build passes (prose-only change; no links/tags added)
  • Grep confirms zero remaining "connection string" references on the 2.1.x accelerator page
  • Wording matches the already-corrected vNext / 2.0.x accelerator pages
  • Files updated: 1 (version-2.1.x accelerator deployment guide)

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

✅ Pull with Spice Passed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected
  • ✅ Has at least one assignee: claudespice

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Pull with Spice Failed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected

Failed checks:

  • ❌ At least one assignee is required for this pull request.

Please address these issues and update your pull request.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 deployed to https://7d89db86.spiceai-org-website.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant