fix: Narrow exception handling in concurrent reset+query test#41
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates ResetTest.testConcurrentResetAndQuery so that IllegalStateException is treated as an unexpected error (alongside NullPointerException) during concurrent reset() + query() operations, aligning the test behavior with its documentation and intent from PR #40.
Changes:
- Record
IllegalStateExceptionas an unexpected error intestConcurrentResetAndQuery(previously swallowed). - Clarify inline comments describing which error types are expected vs unexpected.
- Update the assertion message to mention both NPE and
IllegalStateException.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
phillipleblanc
force-pushed
the
phillipleblanc/fix-concurrent-reset-test
branch
from
March 26, 2026 03:53
768af26 to
959fda2
Compare
lukekim
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
testConcurrentResetAndQuerytest had a catch-allExceptionhandler that silently swallowed all non-NPE exceptions. This meant:IllegalStateException(client incorrectly thinks it's closed during concurrent reset) would pass silentlyExecutionExceptionwrapping an NPE or ISE as its cause would also pass silentlyFix
Replace the catch-all with an
isExpectedTransportError()helper that:ExecutionExceptionto inspect the real cause (sinceSpiceClient.query()wraps retried failures)FlightRuntimeException(gRPC status errors),ConnectException/IOException(connection refused, broken pipe), and messages containing known transport keywordsAddresses review feedback from #40.