perf(executor): per-ExecutionCtx ArrayKernels snapshot#63
Closed
lukekim wants to merge 1 commit into
Closed
Conversation
Resolve ArrayKernels once at ExecutionCtx construction into a KernelSnapshot (an ArcSwapMap::load_full of the execute-parent kernel map) instead of cloning the session and probing the sharded session-variable DashMap on every array node in the execute_until / single-step paths. This also stops holding the session-variable read guard across kernel invocation. The registry is session-scoped and mutable via its public register_* methods: an ExecutionCtx sees a point-in-time snapshot taken at construction, and later registrations are picked up by the next context (contexts are created per evaluation). Adds a pub(crate) ArcSwapMap::load_full accessor; the KernelSnapshot type and ArrayKernels::snapshot() are pub(crate), so no new public API is added. Signed-off-by: Luke Kim <80174+lukekim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves
ArrayKernelsonce atExecutionCtxconstruction into a crate-privateKernelSnapshot(a singleArcSwapMap::load_fullof the execute-parent kernel map), instead of cloning the session and probing the sharded session-variableDashMapon every array node in theexecute_until/ single-step execution paths.Why
DashMapshardRwLockprobe from the hot execution loop.Semantics
The registry is session-scoped and mutable via its public
register_*methods. AnExecutionCtxsees a point-in-time snapshot taken at construction; later registrations are picked up by the next context (contexts are created per evaluation). Kernel lookup order is unchanged: registered plugin kernels are tried before staticexecute_parentkernels, with the same(parent, child)hashing.Adds a
pub(crate)ArcSwapMap::load_fullaccessor (snapshot-that-outlives-the-call, complementingread).KernelSnapshotandArrayKernels::snapshot()arepub(crate)— no new public API.Testing
cargo nextest run -p vortex-array— 2893 passed (includesstruct_cast_execute_parent_uses_session_plugin, covering the register → snapshot → execute path).cargo clippy --all-targets -p vortex-array— clean on the spiceai-53 variant of this change; develop port re-verified via the full test build.Develop-targeting twin of #61 (same change, adapted to the
ArcSwapMaprefactor on develop).