Merge upstream Vortex 0.79.0 into spiceai-54

.clang-format

@@ -25,7 +25,7 @@ DerivePointerAlignment: false
 IncludeBlocks: Regroup
 InsertBraces: true
 Language: Cpp
-NamespaceIndentation: Inner
+NamespaceIndentation: None
 PointerAlignment: Right
 SpaceBeforeCpp11BracedList: true
 SpaceBeforeCtorInitializerColon: true

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,6 +1,6 @@
 name: Bug Report
 description: Report something that isn't working correctly
-labels: ["needs-triage"]
+labels: ["bug"]
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: true
 contact_links:
-  - name: Features, Questions
-    url: https://github.com/vortex-data/vortex/discussions/new/choose
-    about: Our preferred starting point if you have any questions or suggestions about configuration, features or behavior.
+  - name: Community Slack
+    url: https://vortex.dev/slack
+    about: Chat with the community for quick questions and discussion.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -0,0 +1,27 @@
+name: Feature Request
+description: Suggest a new feature or improvement
+labels: ["feature"]
+body:
+  - type: textarea
+    id: problem
+    attributes:
+      label: Problem or motivation
+      description: What are you trying to do that Vortex doesn't support today?
+    validations:
+      required: true
+
+  - type: textarea
+    id: proposal
+    attributes:
+      label: Proposed solution
+      description: What would you like to see happen?
+    validations:
+      required: true
+
+  - type: textarea
+    id: additional
+    attributes:
+      label: Additional context
+      description: Alternatives considered, links, or anything else helpful
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/question.yml

@@ -0,0 +1,24 @@
+name: Question
+description: Ask a question about using or configuring Vortex
+labels: ["question"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Please check the [documentation](https://docs.vortex.dev) first. For quick
+        back-and-forth, try the [Vortex Slack channel](https://vortex.dev/slack).
+
+  - type: textarea
+    id: question
+    attributes:
+      label: What's your question?
+    validations:
+      required: true
+
+  - type: textarea
+    id: context
+    attributes:
+      label: Context
+      description: What you've tried, relevant code, or your environment
+    validations:
+      required: false

.github/actions/setup-prebuild/action.yml

@@ -17,9 +17,9 @@ inputs:
     description: "optional targets override (e.g. wasm32-unknown-unknown)"
     required: false
   enable-sccache:
-    description: "Should sccache be enabled, true by default."
+    description: "Should sccache be enabled."
     required: false
-    default: "true"
+    default: "false"
 
 runs:
   using: "composite"
@@ -46,4 +46,4 @@ runs:
         toolchain: ${{ inputs.toolchain }}
         components: ${{ inputs.components }}
         targets: ${{ inputs.targets }}
-        enable-sccache: ${{ inputs.enable-sccache }}
+        enable-sccache: "false"

.github/actions/setup-rust/action.yml

@@ -17,9 +17,9 @@ inputs:
     description: "optional targets override (e.g. wasm32-unknown-unknown)"
     required: false
   enable-sccache:
-    description: "Should sccache be enabled, true by default."
+    description: "Should sccache be enabled."
     required: false
-    default: "true"
+    default: "false"
 
 runs:
   using: "composite"

.github/workflows/bench-pr.yml

@@ -46,10 +46,11 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          enable-sccache: ${{ github.event.pull_request.head.repo.fork == false && 'true' || 'false' }}
 
       - name: Install DuckDB
         run: |
-          wget -qO- https://github.com/duckdb/duckdb/releases/download/v1.5.3/duckdb_cli-linux-amd64.zip | funzip > duckdb
+          wget -qO- https://github.com/duckdb/duckdb/releases/download/v1.5.4/duckdb_cli-linux-amd64.zip | funzip > duckdb
           chmod +x duckdb
           echo "$PWD" >> $GITHUB_PATH
 

.github/workflows/bench.yml

@@ -60,10 +60,11 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          enable-sccache: ${{ github.repository == 'vortex-data/vortex' && 'true' || 'false' }}
 
       - name: Install DuckDB
         run: |
-          wget -qO- https://github.com/duckdb/duckdb/releases/download/v1.5.3/duckdb_cli-linux-amd64.zip | funzip > duckdb
+          wget -qO- https://github.com/duckdb/duckdb/releases/download/v1.5.4/duckdb_cli-linux-amd64.zip | funzip > duckdb
           chmod +x duckdb
           echo "$PWD" >> $GITHUB_PATH
 
@@ -116,47 +117,29 @@ jobs:
         run: |
           bash scripts/cat-s3.sh vortex-ci-benchmark-results data.json.gz results.json
 
-      - name: Ingest results to v3 server
-        if: vars.V3_INGEST_URL != ''
-        shell: bash
-        env:
-          INGEST_BEARER_TOKEN: ${{ secrets.INGEST_BEARER_TOKEN }}
-        run: |
-          python3 scripts/post-ingest.py results.v3.jsonl \
-            --server "${{ vars.V3_INGEST_URL }}" \
-            --commit-sha "${{ github.sha }}" \
-            --benchmark-id "${{ matrix.benchmark.id }}" \
-            --repo-url "${{ github.server_url }}/${{ github.repository }}"
-
-      # v4 (Postgres) dual-write -- BEST-EFFORT during the migration soak. The
-      # proven v3 step above is hard-required; a v4 failure must NOT fail the job
-      # (v4 is promoted to required at cutover, PR-5.1). Gated on the ingest-role
-      # ARN var (the assume-role input that MUST exist for OIDC to succeed) so it
-      # no-ops until v4 infra is wired, and every step is
-      # `continue-on-error` so an OIDC / uv / connect hiccup never breaks the v3
-      # pipeline. post-ingest.py mints the RDS IAM token internally (boto3) from
-      # the assumed GitHubBenchmarkIngestRole; sslmode=verify-full validates the cert.
+      # v4 (Postgres) ingest -- the REQUIRED benchmark-results pipeline feeding the live
+      # benchmarks website; a failure here fails the job. Gated on the ingest-role ARN var
+      # (the assume-role input that MUST exist for OIDC to succeed). post-ingest.py mints
+      # the RDS IAM token internally (boto3) from the assumed GitHubBenchmarkIngestRole;
+      # sslmode=verify-full validates the cert.
       #
-      # ORDER MATTERS: "Install uv" runs BEFORE "Configure AWS credentials".
-      # configure-aws-credentials persists the assumed ingest-role (rds-db:connect
-      # only) as the job's ambient AWS creds; the uv setup compiles via sccache
-      # (S3-backed), so running it after the role switch fails with S3 AccessDenied.
-      # Installing uv first keeps sccache on the original S3-capable creds; the role
-      # is assumed immediately before the ingest, which needs only rds-db:connect.
+      # `sync: false` -- the ingest runs `uv run --no-project --with`, which needs only
+      # the uv binary, never the synced workspace. A full sync would rebuild
+      # vortex-python via sccache->S3, which fails under the ingest-role creds
+      # (rds-db:connect only) and is pure waste here.
       - name: Install uv for v4 ingest
         if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
-        continue-on-error: true
         uses: spiraldb/actions/.github/actions/setup-uv@a746510eafaa926484c354541cfc49b2ec06cc63  # 0.18.6
+        with:
+          sync: false
       - name: Configure AWS credentials for v4 ingest (OIDC)
         if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
-        continue-on-error: true
         uses: aws-actions/configure-aws-credentials@e7f100cf4c008499ea8adda475de1042d6975c7b  # v6
         with:
           role-to-assume: ${{ vars.GH_BENCH_INGEST_ROLE_ARN }}
           aws-region: ${{ vars.RDS_BENCH_REGION }}
-      - name: Ingest results to v4 Postgres (best-effort)
+      - name: Ingest results to v4 Postgres
         if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
-        continue-on-error: true
         shell: bash
         env:
           RDS_BENCH_INSTANCE_ENDPOINT: ${{ vars.RDS_BENCH_INSTANCE_ENDPOINT }}
@@ -188,3 +171,31 @@ jobs:
     secrets: inherit
     with:
       mode: "develop"
+
+  sql-vortex:
+    uses: ./.github/workflows/sql-benchmarks.yml
+    secrets: inherit
+    with:
+      mode: "develop"
+      benchmark_matrix: |
+        [
+          {
+            "id": "vortex-queries",
+            "subcommand": "vortex",
+            "name": "Vortex queries",
+            "data_formats": ["parquet", "vortex"],
+            "pr_targets": [
+              {"engine": "datafusion", "format": "parquet"},
+              {"engine": "datafusion", "format": "vortex"},
+              {"engine": "duckdb", "format": "parquet"},
+              {"engine": "duckdb", "format": "vortex"}
+            ],
+            "develop_targets": [
+              {"engine": "datafusion", "format": "parquet"},
+              {"engine": "datafusion", "format": "vortex"},
+              {"engine": "duckdb", "format": "parquet"},
+              {"engine": "duckdb", "format": "vortex"}
+            ],
+            "iterations": "100"
+          }
+        ]