Open
Conversation
GoToLoop
reviewed
Dec 4, 2022
|
|
||
| this.encoder.render(); | ||
|
|
||
| return function() { this.encoder.abort() }.bind(this); |
There was a problem hiding this comment.
Using a fat-arrow lambda style would be more compact:
return () => this.encoder.abort();
Author
There was a problem hiding this comment.
that's true, though function() {} is consistent with the existing style in this file which does not use =>
There was a problem hiding this comment.
In case fat-arrow syntax isn't allowed, here's an alternative style w/o .bind(this):
this.callback = callback;
const enc = this.encoder;
enc.render();
return function() { enc.abort(); };
}
Author
|
This PR is mostly to share my workaround I've been using. Rather than expecting it to be merged. If there are better suggestions to achieve the functionality, they can be shared here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for aborting GIF encoding.
Encoding the captured frames as a GIF can take a long time. Especially when there are many frames. Users may want to abort the GIF encoding after it starts.
The gif.js library supports this with an abort() function. But the CCapture object doesn't expose the gif.js encoder to the caller. This prevents gif.js's
abort()function from being callable.This pull request modifies the
CCGIFEncoder'ssave()function to return the gif.jsabort()function: