added ability to sync video with capture#60
Open
MatthewRayfield wants to merge 1 commit intospite:masterfrom
Open
added ability to sync video with capture#60MatthewRayfield wants to merge 1 commit intospite:masterfrom
MatthewRayfield wants to merge 1 commit intospite:masterfrom
Conversation
Owner
|
This looks really good, thanks! A few ideas to build upon this:
Nice work! |
|
Excellent method, works pretty good, however the "ended" listener is not working while capturing, I need to use it to trigger capturer.save(); Thanks |
|
thank you Matthew! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌻 Addresses #53 🌻
Adds a setting named "syncVideo". If a video element is provided for this setting it is synced with the framerate of the capture using the following method:
🦆 @spite I'll be interested to hear your thoughts 🦆