Merge for first release

.github/workflows/python-self-hosted.yaml → .github/workflows/python-ci.yaml

@@ -1,15 +1,18 @@
-# .github/workflows/python-self-hosted.yml
-name: Python CI (Self-hosted)
+# .github/workflows/python-ci.yml
+name: Python CI
 
 on:
   push:
-    branches: [ "main" ]
+    branches: [ "main", "dev" ]
   pull_request:
-    branches: [ "main" ]
+    branches: [ "main", "dev" ]
 
 jobs:
   build:
-    runs-on: self-hosted
+    runs-on: ubuntu-latest
+
+    env:
+      DATASTORE_EMULATOR_HOST: "localhost:8081"
 
     steps:
     - name: Checkout code
@@ -19,13 +22,25 @@ jobs:
       uses: actions/setup-python@v5
       with:
         python-version: '3.13'
-
+
+    - name: Set up Java (required for Datastore emulator)
+      uses: actions/setup-java@v4
+      with:
+        distribution: 'temurin'
+        java-version: '21'
+
     - name: 'Set up Cloud SDK'
       uses: 'google-github-actions/setup-gcloud@v2'
       with:
-        install_components: 'cloud-datastore-emulator'
+        install_components: 'beta,cloud-datastore-emulator'
+
+    - name: 'Verify gcloud setup'
+      run: |
+        gcloud --version
+        which gcloud
+        gcloud components list --filter="id:cloud-datastore-emulator" --format="table(id,state.name)"
 
-    - name: 'Use gcloud CLI'
+    - name: 'Configure gcloud project'
       run: 'gcloud config set project python-datastore-sqlalchemy'
 
     - name: Install dependencies

README.md

@@ -18,6 +18,8 @@ print(result.fetchall())
 ## Preview
 <img src="assets/pie.png">
 
+## How to contribute
+Feel free to open issues and pull requests on github.
 
 ## References
 - [Develop a SQLAlchemy dialects](https://hackmd.io/lsBW5GCVR82SORyWZ1cssA?view)

pyproject.toml

@@ -0,0 +1,21 @@
+[tool.ruff]
+line-length = 120
+
+[tool.ruff.lint]
+select = ["E", "F", "W", "I", "N", "B", "C", "G", "S"]
+ignore = [
+    "E501",  # Line too long - allow longer lines for SQL strings in tests
+    "S608",  # SQL injection - intentional for test cases
+    "B007",  # Loop variable not used - common in test assertions
+]
+
+[tool.ruff.lint.per-file-ignores]
+"tests/*" = ["S608", "E501", "S101", "B007", "S603"]
+
+[tool.mypy]
+ignore_missing_imports = true
+disable_error_code = ["var-annotated", "import-untyped"]
+
+[[tool.mypy.overrides]]
+module = ["tests.*", "sqlalchemy_datastore.*"]
+ignore_errors = true

requirements.txt

@@ -9,7 +9,7 @@ pytest-cov==6.2.1
 pytest-html==4.1.1
 pytest-mypy==1.0.1
 pytest-ruff==0.5
-pytest-dotenv==0.5.2
 flake8==7.3.0
 coverage==7.9.2
-sqlglotrs==0.6.2
+pandas==2.3.3
+sqlglot==28.6.0

sqlalchemy_datastore/base.py

@@ -62,6 +62,10 @@ class CloudDatastoreDialect(default.DefaultDialect):
     returns_unicode_strings = True
     description_encoding = None
 
+    # JSON support - required for SQLAlchemy JSON type
+    _json_serializer = None
+    _json_deserializer = None
+
     paramstyle = "named"
 
     def __init__(
@@ -256,13 +260,13 @@ def _contains_select_subquery(self, node) -> bool:
     def do_execute(
         self,
         cursor,
-        # cursor: DBAPICursor, TODO: Uncomment when superset allow sqlalchemy version >= 2.0 
+        # cursor: DBAPICursor, TODO: Uncomment when superset allow sqlalchemy version >= 2.0
         statement: str,
-        # parameters: Optional[], TODO: Uncomment when superset allow sqlalchemy version >= 2.0 
+        # parameters: Optional[], TODO: Uncomment when superset allow sqlalchemy version >= 2.0
         parameters,
         context: Optional[ExecutionContext] = None,
     ) -> None:
-        cursor.execute(statement)
+        cursor.execute(statement, parameters)
 
     def get_view_names(
         self, connection: Connection, schema: str | None = None, **kw: Any