Corrected the logs and added text script#110
Merged
Merged
Conversation
K0S_QUICKSTART.md was removed during doc consolidation. Replace with DEPLOYMENT_GUIDE.md and TROUBLESHOOTING.md which are the current docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…th summary The post-install banner was listing PodInitializing workers alongside actual failures (e.g. ImagePullBackOff on the head pod), making it hard to identify what to fix. Now root-cause pods and downstream initializing pods are printed in separate sections with a clear tip to fix root causes first. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When there are no root-cause pods (e.g. head pod recovered but workers still initializing), the tip no longer says "waiting on root-cause pod(s) above" where there is nothing above. Instead shows "still starting up — re-run verifier in a few minutes". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…unctions Covers build_image_url, object_store_auth_looks_like_placeholder, _pod_is_healthy, _classify_pod_failure, and _print_unhealthy_pod_summary (4 scenarios including mixed root-cause/PodInitializing, only-initializing, only-root-cause multi-namespace, and truncation). No cluster or network needed. Run: ./tools/cluster_setup/test_k0s_cluster_with_stack.sh [-v] [filter] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the k0s cluster setup tooling to produce a more actionable “unhealthy pods” banner summary (separating root-cause failures from downstream initializing pods), refreshes the documentation links printed in the post-install output, and adds a lightweight bash-based unit test script for the script’s pure-logic helper functions.
Changes:
- Improve
_print_unhealthy_pod_summaryoutput by separating root-cause pods from downstreamPodInitializingpods and adjusting banner tips accordingly. - Update
show_platform_access_infodocumentation links to point to the deployment and troubleshooting guides. - Add
tools/cluster_setup/test_k0s_cluster_with_stack.shwith unit tests for selected pure-logic functions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tools/cluster_setup/k0s_cluster_with_stack.sh | Refines unhealthy-pod summary output and updates documentation links in the banner. |
| tools/cluster_setup/test_k0s_cluster_with_stack.sh | Adds a bash unit-test harness for pure-logic helpers used by the cluster setup script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
k0s_cluster_with_stack.sh: - Remove no-op total=$(( total )) assignment - Restore max_per_ns named variable in _print_pod_section - Move _print_pod_section to a top-level helper (was re-defined as a global on every call to _print_unhealthy_pod_summary) test_k0s_cluster_with_stack.sh: - Drop set -e (grep -c returns exit 1 on zero matches, causing early exit) - Add || true to all grep -c expressions to make them non-fatal - Extract functions by name via _extract_fn() instead of brittle hard-coded line ranges; robust to unrelated edits shifting line numbers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…local - Output format comment now shows the root-cause / still-initializing section headers instead of the old single-section format - Remove unused unhealthy_lines local (superseded by root_cause_lines and downstream_lines) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vavarshn
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Changes Made
Testing Performed
make test)make lint)Test Environment
Test Steps
Documentation
Checklist
Breaking Changes
Impact:
Migration Path:
Screenshots/Recordings
Additional Notes
Reviewer Notes
Please pay special attention to:
Commit Message Convention: This PR follows Conventional Commits