docs(k0s): align SAIA exposure guidance — NodePort as portable default#111
Merged
Conversation
kupratyu-splunk
approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the k0s cluster setup configuration to change how the SAIA “public” service is exposed and to clarify the intended exposure options (NodePort vs LoadBalancer/MetalLB) in the k0s installer context.
Changes:
- Switch the default SAIA
serviceTemplate.typefromLoadBalancertoNodePortand introduce a fixednodePortvalue. - Update the SAIA public exposure guidance comments to describe when to use NodePort vs MetalLB-backed LoadBalancer.
- Disable MetalLB installation by default (
metallb.install: false) and expand the MetalLB usage notes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolve contradictory messaging between the config template and the installer: the config comment block now presents NodePort as the default/portable option (works on cloud VPCs where MetalLB L2 cannot) and frames LoadBalancer+MetalLB as the bare-metal-only alternative. Replace the stale 'NodePort exposure is discouraged' WARNING in the installer with an informational line that prints the access URL. Co-Authored-By: Claude <noreply@anthropic.com>
kbhos-splunk
changed the title
kupratyu-splunk
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Changes Made
Testing Performed
make test)make lint)Test Environment
Test Steps
Documentation
Checklist
Breaking Changes
Impact:
Migration Path:
Screenshots/Recordings
Additional Notes
Reviewer Notes
Please pay special attention to:
Commit Message Convention: This PR follows Conventional Commits