Enable PR linting with Danger#9
Open
harpojaeger wants to merge 11 commits intospokecommunity:masterfrom
Open
Conversation
This will not be necessary with yarn.
bchrobot
approved these changes
Mar 21, 2019
| const resultsTableHeader = '### Linter results\r|File|Errors|Warnings\r|---|---|---|\r' | ||
| const resultsTableRows = lintReport.results.map(file => { | ||
| const travisBasePath = /home\/travis\/build\/\w+\/Spoke\// | ||
| const localPath = file.filePath.replace(travisBasePath, '') |
Member
There was a problem hiding this comment.
I think moving this outside of map will provide better performance
| const { modified_files: modified, created_files: created } = danger.git | ||
| const linter = new CLIEngine(config) | ||
| const lintReport = linter.executeOnFiles([...modified, ...created]) | ||
| // console.log(lintReport.results) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables automatic linting of the files that were changed in any given PR. On success, a message like this one is added by a bot:
On failure/warning, it looks like this:
After this is merged, some trivial Travis CI setup is necessary to complete the process (I'll handle that).
dangerfile.jsis where the actual linting logic is performed (this can be used for lots of things besides linting). Updates to.travis.ymlare necessary to actually run Danger as part of CI. It was necessary to make.eslintrcinto a JSON file so it could be imported and parsed in the Dangerfile. Also, I disabled auto-fixing in the defaultnpm run lintscript.