fix(cli): drop twitter-bookmarks default from connector-sync#87
Merged
fix(cli): drop twitter-bookmarks default from connector-sync#87
Conversation
The default dated from single-connector days. With multi-connector packages (github, xhs, reddit, hn), defaulting to twitter-bookmarks is misleading. Omitting the argument now lists installed connectors and prints usage instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The file uses `join(__dirname, ...)` to resolve bundled-connectors, but the package is ESM — __dirname is undefined and the subcommand crashed on invocation. Derive it from import.meta.url. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spool connector-syncno longer defaultsconnector-idtotwitter-bookmarks— stale since multi-connector packages landed (feat: exec capability, GitHub connector, and multi-connector support #70). Running with no args now lists installed connectors and prints usage (exit 0)__dirnamewas referenced directly but the package is"type": "module", so the subcommand crashed on invocation. Derived fromimport.meta.urlTest plan
pnpm --filter @spool/cli buildpassesspool connector-syncwith no args lists 8 connectors, exits 0spool connector-sync bogus-iderrors with available list🤖 Generated with Claude Code