fix(prereq): accept zero-padded CalVer + align Setup card icons#90
Merged
fix(prereq): accept zero-padded CalVer + align Setup card icons#90
Conversation
…rst line Prereq checker used semver.valid() directly, which rejects zero-padded CalVer like yt-dlp's 2026.03.17 (semver disallows leading zeros in any numeric segment). Detection landed on "Could not parse detected version" even when the regex matched the output. Normalize by stripping leading zeros from numeric segments before handing to semver — ordering is preserved and existing semver-shaped versions are unaffected. Also in the Setup card, switch the row from items-center to items-start and wrap status + action icons in fixed-height spans so they sit at the first-line center instead of being centered against (label + hint), which visually drifted downward whenever a prereq had a hint below the label (e.g. error cases). Discovered while onboarding @graydawnc/connector-youtube — yt-dlp hit both issues at once. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes surfaced while onboarding a YouTube connector (yt-dlp).
1. Zero-padded CalVer broke prereq detection
prerequisites.tshanded the detected version string straight tosemver.valid(). yt-dlp uses CalVer like2026.03.17— semver disallows leading zeros in numeric segments, so even though the regex matched, the checker returned "Could not parse detected version" and the prereq sat in an error state forever. Same trap would bite any CalVer-padded dep (Ubuntu, Postgres, many Python packages).Fix: strip leading zeros from numeric segments before
valid()/gte(). Ordering is preserved, existing semver-shaped inputs unchanged.2. Setup card status icon drifted below the label row
The prereq row used
items-center. When a prereq had a hint below the label (error/outdated cases), the status icon centered against the full two-line height and visually floated down between the label and the hint. Same for the right-side action button.Fix:
items-starton the row + fixed-height wrappers around the icon / action so they sit at the first-line center.Test plan
2026.03.17, still mark2024.02.05as outdated vs2024.03.01)@graydawnc/connector-youtubeon dev box → yt-dlp detection now resolves to ok with2026.03.17displayed🤖 Generated with Claude Code