Improve lock performance#220
Draft
kmcbride wants to merge 2 commits into
Draft
Conversation
kmcbride
commented
Apr 15, 2026
3675508 to
c599812
Compare
c599812 to
51acc63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces existing
NSRecursiveLockand serialDispatchQueuesynchronization with unfair locks. This isn't usingOSAllocatedUnfairLockdue to the supported deployment targets, but it's something to consider in the future.There's also an additional tweak with a much more modest (~10%) improvement for resolving route handlers.