Use native AbortSignal.timeout (if exists)#261
Open
andreas-karlsson wants to merge 2 commits intomainfrom
Open
Use native AbortSignal.timeout (if exists)#261andreas-karlsson wants to merge 2 commits intomainfrom
andreas-karlsson wants to merge 2 commits intomainfrom
Conversation
andreas-karlsson
requested review from
Billlynch,
fabriziodemaria,
mfranberg,
nicklasl,
nickybondarenko and
vahidlazio
as code owners
nicklasl
reviewed
Apr 30, 2025
Comment on lines
+23
to
+29
| const timeoutPolyfill: (typeof AbortSignal)['timeout'] = milliseconds => { | ||
| const controller = new AbortController(); | ||
| setTimeout(() => { | ||
| controller.abort(new DOMException('signal timed out', 'TimeoutError')); | ||
| }, milliseconds); | ||
| return controller.signal; | ||
| }; |
Member
There was a problem hiding this comment.
This does not contain the "special stuff" we previously had for NodeJS. Will all node version contain the native AbortSignal.timeout?
this
// in Node setTimeout returns an object, with an unref function which will prevent the timeout from keeping the process alive
if (typeof timeoutId === 'object') timeoutId.unref();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to also update typescript, cause AbortSignal.any wasn't available in the standard lib types for the version we were using.