Fix incorrect error message in Istft layer validation#15
Open
Nepomuk5665 wants to merge 1 commit into
Open
Conversation
The error message stated 'FFT Length must be less than or equal to hop length' but the condition raises when fft_length <= hop_length, meaning the requirement is for fft_length > hop_length. Corrected the message to accurately describe the constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an incorrect error message in the
Istftlayer's__init__validation that was stating the opposite of the actual requirement.The Bug
In
realbook/layers/signal.py:184-186:The error message says "FFT Length must be less than or equal to hop length" but the condition raises an error when
fft_length <= hop_length. This means the actual requirement isfft_length > hop_length.The Fix
Changed the error message to accurately describe the constraint:
This matches:
fft_length <= hop_lengthtriggers the error)