Skip to content

Update LocationRewriteFilter.java#3489

Open
ghost wants to merge 1 commit intospring-cloud:mainfrom
tombueng:patch-1
Open

Update LocationRewriteFilter.java#3489
ghost wants to merge 1 commit intospring-cloud:mainfrom
tombueng:patch-1

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 29, 2019

Do not fail on unknown http status codes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2019

Codecov Report

Merging #3489 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3489      +/-   ##
============================================
+ Coverage     64.93%   64.95%   +0.01%     
  Complexity     1498     1498              
============================================
  Files           189      189              
  Lines          7253     7254       +1     
  Branches        863      864       +1     
============================================
+ Hits           4710     4712       +2     
+ Misses         2230     2228       -2     
- Partials        313      314       +1
Impacted Files Coverage Δ Complexity Δ
...tflix/zuul/filters/post/LocationRewriteFilter.java 87.5% <50%> (-1.6%) 18 <0> (ø)
...x/ribbon/apache/HttpClientRibbonConfiguration.java 97.56% <0%> (+4.87%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6ec15...d216746. Read the comment docs.

Copy link
Copy Markdown
Contributor

@ryanjbaxter ryanjbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test that demonstrates the issue.

Also please submit this against the 2.0.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants