Skip to content

DO NOT MERGE: Avoid cycle in getScheme().#3983

Draft
OlgaMaciaszek wants to merge 1 commit intomainfrom
avoid-cycle-in-getScheme
Draft

DO NOT MERGE: Avoid cycle in getScheme().#3983
OlgaMaciaszek wants to merge 1 commit intomainfrom
avoid-cycle-in-getScheme

Conversation

@OlgaMaciaszek
Copy link
Copy Markdown
Collaborator

Changes necessary after merging: spring-cloud/spring-cloud-commons#937.
Only merge after the commons PR is merged.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2021

Codecov Report

Merging #3983 (993f4ee) into master (9804818) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3983      +/-   ##
============================================
+ Coverage     55.11%   55.15%   +0.03%     
- Complexity      507      508       +1     
============================================
  Files            57       57              
  Lines          2464     2466       +2     
  Branches        228      228              
============================================
+ Hits           1358     1360       +2     
+ Misses         1019     1018       -1     
- Partials         87       88       +1     
Impacted Files Coverage Δ Complexity Δ
...rk/cloud/netflix/eureka/EurekaServiceInstance.java 48.00% <66.66%> (+0.17%) 8.00 <1.00> (ø)
.../netflix/eureka/server/EurekaServerConfigBean.java 22.73% <0.00%> (+0.23%) 32.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9804818...993f4ee. Read the comment docs.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.15%. Comparing base (9804818) to head (993f4ee).
⚠️ Report is 774 commits behind head on main.

Files with missing lines Patch % Lines
...rk/cloud/netflix/eureka/EurekaServiceInstance.java 66.66% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3983      +/-   ##
============================================
- Coverage     55.15%   55.15%   -0.01%     
  Complexity      508      508              
============================================
  Files            57       57              
  Lines          2464     2466       +2     
  Branches        228      228              
============================================
+ Hits           1359     1360       +1     
  Misses         1018     1018              
- Partials         87       88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants