Skip to content

Shut down client on stop.#4213

Open
OlgaMaciaszek wants to merge 1 commit intomainfrom
add-crac-support
Open

Shut down client on stop.#4213
OlgaMaciaszek wants to merge 1 commit intomainfrom
add-crac-support

Conversation

@OlgaMaciaszek
Copy link
Copy Markdown
Collaborator

No description provided.

@OlgaMaciaszek OlgaMaciaszek added this to the 4.1.0-RC1 milestone Oct 19, 2023
@OlgaMaciaszek OlgaMaciaszek self-assigned this Oct 19, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (522905b) 55.62% compared to head (dbbde33) 55.67%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4213      +/-   ##
============================================
+ Coverage     55.62%   55.67%   +0.04%     
- Complexity      527      529       +2     
============================================
  Files            58       58              
  Lines          2684     2698      +14     
  Branches        249      251       +2     
============================================
+ Hits           1493     1502       +9     
- Misses         1104     1108       +4     
- Partials         87       88       +1     
Files Coverage Δ
...mework/cloud/netflix/eureka/CloudEurekaClient.java 35.29% <47.82%> (+10.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanjbaxter
Copy link
Copy Markdown
Contributor

How is this assisting with CraC support?

@spencergibb
Copy link
Copy Markdown
Member

Anything with Lifecycle implementations is where checkpoint restore comes in

@spencergibb spencergibb removed this from the 4.1.0-RC1 milestone Dec 6, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.67%. Comparing base (522905b) to head (dbbde33).
⚠️ Report is 464 commits behind head on main.

Files with missing lines Patch % Lines
...mework/cloud/netflix/eureka/CloudEurekaClient.java 47.82% 11 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4213      +/-   ##
============================================
+ Coverage     55.62%   55.67%   +0.04%     
- Complexity      527      529       +2     
============================================
  Files            58       58              
  Lines          2684     2698      +14     
  Branches        249      251       +2     
============================================
+ Hits           1493     1502       +9     
- Misses         1104     1108       +4     
- Partials         87       88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants