Fix observationConvention propagation to child chains (#5882)#5886
Open
redinside-dev wants to merge 1 commit intospring-projects:mainfrom
Open
Fix observationConvention propagation to child chains (#5882)#5886redinside-dev wants to merge 1 commit intospring-projects:mainfrom
redinside-dev wants to merge 1 commit intospring-projects:mainfrom
Conversation
…dAdvisorChain Fixes spring-projects#5882 - The Advisor executed after ToolCallAdvisor lacks the custom observation convention about 'spring.ai.advisor' span. The copyAdvisorsAfter() method now passes the parent chain's observationConvention to the child chain builder, ensuring custom observation conventions are inherited by child chains. Added tests to verify: - Custom observation convention is preserved when copying call chains - Default observation convention is preserved when copying call chains - Custom observation convention is preserved when copying stream chains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5882 - The Advisor executed after ToolCallAdvisor lacks the custom observation convention about 'spring.ai.advisor' span.
Problem
In
DefaultAroundAdvisorChain.copyAdvisorsAfter(), when creating child chains for advisors that come after a certain advisor, theobservationConventionfrom the parent chain was not being passed to the child chain builder. This caused subsequent advisors in the chain to lose the custom observation convention.Solution
Pass
this.observationConventionto the builder incopyAdvisorsAfter():Changes
.observationConvention(this.observationConvention)to the builder chain incopyAdvisorsAfter()whenCopyingChainWithCustomObservationConventionThenConventionIsPreservedwhenCopyingChainWithDefaultObservationConventionThenDefaultIsPreservedwhenCopyingStreamChainThenObservationConventionIsPreservedTesting
All existing tests pass, plus the 3 new tests verify the fix.