Skip to content

Add XML guidance to authorizeRequests deprecation warning #19033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hqqw2h-lgtm wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Add XML guidance to authorizeRequests deprecation warning #19033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ingframework/security/config/annotation/web/builders/WebSecurityFilterChainValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,15 @@ private void checkAuthorizationFilters(List<SecurityFilterChain> chains) {
}
if (authorizationFilter != null && filterSecurityInterceptor != null) {
this.logger.warn(
"It is not recommended to use authorizeRequests or FilterSecurityInterceptor in the configuration. Please only use authorizeHttpRequests");
"It is not recommended to use authorizeRequests or FilterSecurityInterceptor in the configuration. "
+ "Please only use authorizeHttpRequests. "
+ "For XML configuration, please add use-authorization-manager=\"true\" to your <http> element.");
}
if (filterSecurityInterceptor != null) {
this.logger.warn(
"Usage of authorizeRequests and FilterSecurityInterceptor are deprecated. Please use authorizeHttpRequests in the configuration");
"Usage of authorizeRequests and FilterSecurityInterceptor are deprecated. "
+ "Please use authorizeHttpRequests in the configuration. "
+ "For XML configuration, please add use-authorization-manager=\"true\" to your <http> element.");
}
authorizationFilter = null;
filterSecurityInterceptor = null;
Expand Down
8 changes: 6 additions & 2 deletions ...g/src/main/java/org/springframework/security/config/http/DefaultFilterChainValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,15 @@ private void checkAuthorizationFilters(List<SecurityFilterChain> chains) {
}
if (authorizationFilter != null && filterSecurityInterceptor != null) {
this.logger.warn(
"It is not recommended to use authorizeRequests or FilterSecurityInterceptor in the configuration. Please only use authorizeHttpRequests");
"It is not recommended to use authorizeRequests or FilterSecurityInterceptor in the configuration. "
+ "Please only use authorizeHttpRequests. "
+ "For XML configuration, please add use-authorization-manager=\"true\" to your <http> element.");
}
if (filterSecurityInterceptor != null) {
this.logger.warn(
"Usage of authorizeRequests and FilterSecurityInterceptor are deprecated. Please use authorizeHttpRequests in the configuration");
"Usage of authorizeRequests and FilterSecurityInterceptor are deprecated. "
+ "Please use authorizeHttpRequests in the configuration. "
+ "For XML configuration, please add use-authorization-manager=\"true\" to your <http> element.");
}
authorizationFilter = null;
filterSecurityInterceptor = null;
Expand Down