Fix TypeError when time entities used for discharge/charge hour config with GS_fb00 by Copilot · Pull Request #3826 · springfall2008/batpred

Copilot · 2026-04-24T07:54:28Z

Solis GS_fb00 (FB00 firmware) exposes time.* entities for TOU slots rather than separate number.* hour/minute entities. When discharge_start_hour/discharge_end_hour (and charge equivalents) are mapped to these time entities, PredBat crashes in write_and_poll_option because integer hour values (e.g. 22) are passed to ":" in new_value.

Changes

write_and_poll_option — defensive fix: Convert new_value to str before the ":" in new_value check, preventing TypeError: argument of type 'int' is not iterable for any integer passed to a time/select entity.
adjust_force_export — correct fix: When inv_charge_time_format == "H M", detect if discharge_start_hour, discharge_start_minute, discharge_end_hour, or discharge_end_minute resolves to a time.* entity. If so, write the full time string ("HH:MM:SS") instead of the extracted integer component — which would otherwise produce an invalid value and overwrite the minutes to :00.
adjust_charge_window — same fix: Applied the same detection and full-time-string write for charge_start_hour, charge_start_minute, charge_end_hour, and charge_end_minute.
TestHAInterface — mock extended: Added time/set_value service handling so the test mock correctly updates entity state when a time.* entity is written.
Unit tests added: test_time_entity_hour_write in tests/test_inverter.py covers both adjust_force_export and adjust_charge_window with time.* entities, verifying the full "HH:MM:SS" string is written and no TypeError is raised.

Entity domain detection uses startswith("time.") rather than .split(".")[0] to avoid a potential IndexError.

# apps.yaml — FB00 firmware setup that previously crashed on discharge
discharge_start_hour:
  - time.solis_rhi_3p_grid_time_of_use_discharge_start_slot_1
discharge_end_hour:
  - time.solis_rhi_3p_grid_time_of_use_discharge_end_slot_1

…rge_end_hour with GS_fb00 Agent-Logs-Url: https://github.com/springfall2008/batpred/sessions/a836cefc-6427-4317-bd5d-9925b5d073c4 Co-authored-by: springfall2008 <48591903+springfall2008@users.noreply.github.com>

…heck Agent-Logs-Url: https://github.com/springfall2008/batpred/sessions/a836cefc-6427-4317-bd5d-9925b5d073c4 Co-authored-by: springfall2008 <48591903+springfall2008@users.noreply.github.com>

Gammaed · 2026-04-24T10:47:06Z

This fix solves my exact problem.
Tested on Solis RHI-3P10K-HVES-5G firmware 1A0040-60000D
with GS_fb00 inverter type and time entities.
Please merge this fix!

Copilot

Pull request overview

Fixes crashes and incorrect writes when Solis GS_fb00 exposes TOU slot controls as time.* entities (instead of separate hour/minute number.* entities), ensuring PredBat can safely write charge/discharge windows using either representation.

Changes:

Harden write_and_poll_option by coercing new_value to str before string operations, preventing TypeError when integers are passed.
Update adjust_force_export to detect time.* entities for discharge slot hour/minute configs and write the full "HH:MM:SS" string instead of integer components.
Apply the same time.* detection/full-time write behavior in adjust_charge_window for charge slot hour/minute configs.

Copilot · 2026-04-24T10:56:32Z

+                    # If the entity is a time entity (e.g. for FB00 firmware), write the full time string instead of just the integer component
+                    start_hour_id = self.base.get_arg("charge_start_hour", indirect=False, index=self.id)
+                    if start_hour_id and isinstance(start_hour_id, str) and start_hour_id.startswith("time."):
+                        self.write_and_poll_option("charge_start_hour", start_hour_id, new_start)
+                    else:
+                        self.write_and_poll_option("charge_start_hour", start_hour_id, int(new_start[:2]))
+                    start_minute_id = self.base.get_arg("charge_start_minute", indirect=False, index=self.id)
+                    if start_minute_id and isinstance(start_minute_id, str) and start_minute_id.startswith("time."):
+                        self.write_and_poll_option("charge_start_minute", start_minute_id, new_start)
+                    else:
+                        self.write_and_poll_option("charge_start_minute", start_minute_id, int(new_start[3:5]))


The new behavior for GS_fb00/time.* entities (writing full "HH:MM:SS" to _hour/_minute when those config args resolve to time.) isn’t covered by existing inverter tests. Please add a unit test case (e.g., in apps/predbat/tests/test_inverter.py) that sets discharge/charge *_hour (and optionally _minute) to a time. entity and verifies adjust_force_export/adjust_charge_window call the time service with the full time string and don’t attempt to write integer components.

springfall2008 · 2026-04-24T10:57:03Z

@copilot add unit test for this change

…rt and adjust_charge_window Agent-Logs-Url: https://github.com/springfall2008/batpred/sessions/e47fd91a-a100-445a-9cc2-a846d6d2a8d1 Co-authored-by: springfall2008 <48591903+springfall2008@users.noreply.github.com>

Copilot · 2026-04-24T11:02:15Z

@copilot add unit test for this change

Done in commit f325a2d. Added test_time_entity_hour_write in test_inverter.py with 4 test cases (discharge and charge, two time values each). The tests verify that adjust_force_export and adjust_charge_window write the full "HH:MM:SS" string to time.* entities rather than integer hour components, and confirm no TypeError is raised. Also added time/set_value handling to TestHAInterface in test_infra.py so the mock correctly updates dummy_items when a time entity is written.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

gitlab.com
- Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED (dns block)
https://api.github.com/repos/springfall2008/batpred/contents/apps/predbat
- Triggering command: /home/REDACTED/work/batpred/batpred/coverage/venv/bin/python3 python3 ../apps/predbat/unit_test.py --quick --test inverter (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Gammaed · 2026-04-24T18:02:56Z

Looking forward for the update, this is the fix I need and waiting for. Thank you 😊👍

Initial plan

67735f1

Copilot AI assigned Copilot and springfall2008 Apr 24, 2026

Copilot started work on behalf of springfall2008 April 24, 2026 07:54 View session

Copilot AI linked an issue Apr 24, 2026 that may be closed by this pull request

TypeError: argument of type 'int' is not iterable with GS_fb00 + time entities for discharge_start_hour/discharge_end_hour #3824

Closed

Copilot AI and others added 2 commits April 24, 2026 08:04

Use startswith("time.") instead of split[0] for safer entity domain c…

4918881

…heck Agent-Logs-Url: https://github.com/springfall2008/batpred/sessions/a836cefc-6427-4317-bd5d-9925b5d073c4 Co-authored-by: springfall2008 <48591903+springfall2008@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix TypeError when using time entities for discharge hours~~ Fix TypeError when time entities used for discharge/charge hour config with GS_fb00 Apr 24, 2026

Copilot finished work on behalf of springfall2008 April 24, 2026 08:08

Copilot AI requested a review from springfall2008 April 24, 2026 08:08

springfall2008 marked this pull request as ready for review April 24, 2026 10:52

Copilot AI review requested due to automatic review settings April 24, 2026 10:52

Copilot started reviewing on behalf of springfall2008 April 24, 2026 10:52 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Copilot started work on behalf of springfall2008 April 24, 2026 10:57 View session

Copilot finished work on behalf of springfall2008 April 24, 2026 11:03

springfall2008 merged commit 58159d7 into main Apr 25, 2026
1 check passed

springfall2008 deleted the copilot/fix-typeerror-discharge-hours branch April 25, 2026 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix TypeError when time entities used for discharge/charge hour config with GS_fb00#3826

Fix TypeError when time entities used for discharge/charge hour config with GS_fb00#3826
springfall2008 merged 4 commits intomainfrom
copilot/fix-typeerror-discharge-hours

Copilot AI commented Apr 24, 2026 •

edited

Loading

Uh oh!

Gammaed commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

springfall2008 commented Apr 24, 2026

Uh oh!

Copilot AI commented Apr 24, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Gammaed commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Gammaed commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

springfall2008 commented Apr 24, 2026

Uh oh!

Copilot AI commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Gammaed commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 24, 2026 •

edited

Loading

Copilot AI commented Apr 24, 2026 •

edited

Loading