Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Fox ESS scheduler write/read inconsistencies by tracking the device’s original scheduler slot count and ensuring written schedules are padded back to that same count, avoiding schedule-length mismatches.
Changes:
- Add schedule padding support (
target_count) tovalidate_schedule()and persist the device’s scheduler group count for later writes. - Remove the unused
device_current_schedulestate and switch event serial matching to usedevice_detail. - Expand Fox API tests to cover schedule padding behavior and assert the tracked scheduler slot count.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/fox.py | Track scheduler group count, pad validated schedules to device slot count, remove device_current_schedule, and update schedule write/test helpers. |
| apps/predbat/predbat.py | Bump version to v8.37.5. |
| apps/predbat/tests/test_fox_api.py | Update mocks for new state, add padding-focused tests, and validate device_scheduler_count. |
| apps/predbat/tests/test_fox_oauth.py | Remove device_current_schedule from the OAuth test mock state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.