Semantic HTML improvements#343
Open
sarah-j-lancaster wants to merge 8 commits intofeature/react-18-useidfrom
Open
Semantic HTML improvements#343sarah-j-lancaster wants to merge 8 commits intofeature/react-18-useidfrom
sarah-j-lancaster wants to merge 8 commits intofeature/react-18-useidfrom
Conversation
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
| color: var(--colorPageLinks); | ||
| background-color: transparent; | ||
| font: 16px/1.5 sans-serif; | ||
| font-weight: bold; |
There was a problem hiding this comment.
AI guess there's a question of how styled this should be. Are our current buttons bold? https://react-accessible-accordion.springload.co.nz/
Author
There was a problem hiding this comment.
This is the Show code button css, yep its bold, I just moved the rule down to be with the other text ones
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
| DivAttributes, | ||
| Exclude<keyof DivAttributes, keyof InjectedButtonAttributes> | ||
| ButtonAttributes, | ||
| Exclude<keyof ButtonAttributes, keyof InjectedButtonAttributes> |
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
holloway
reviewed
Dec 19, 2021
sarah-j-lancaster
force-pushed
the
semantic-buttons
branch
2 times, most recently
from
dcb28e3 to
9e23bb6
Compare
sarah-j-lancaster
force-pushed
the
semantic-buttons
branch
from
9e23bb6 to
a2c2168
Compare
sarah-j-lancaster
force-pushed
the
semantic-buttons
branch
from
a2c2168 to
9e12c09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keen to merge into the React 18 branch so the changes can go out in a major together?
Open to maybe also changing the prop name because now it seems a bit weird?