Skip to content

CC-38848 Drain publish queue while waiting for deleted attachments to clear#367

Draft
stereomon wants to merge 2 commits into
masterfrom
bugfix/cc-38848-drain-queue-while-waiting-attachment-delete
Draft

CC-38848 Drain publish queue while waiting for deleted attachments to clear#367
stereomon wants to merge 2 commits into
masterfrom
bugfix/cc-38848-drain-queue-while-waiting-attachment-delete

Conversation

@stereomon

Copy link
Copy Markdown
Collaborator

Summary

product-attachment-storefront.cy.ts "…cannot see attachments after they are deleted in backoffice" flakes run-to-run on master compat CI. Root cause is test-infra, not product code: the delete's publish→sync is a multi-stage queue chain, and reloadUntilGone reloaded the PDP but never re-drained the queue between reloads (unlike reloadUntilFound), so a lagging sync message never landed and the list never disappeared ("exhausted retries").

Fix: reloadUntilGone now takes a commands arg (mirroring reloadUntilFound) and re-runs the queue worker on every reload, so the wait keeps draining until storage actually reflects the delete.

Jira: https://spryker.atlassian.net/browse/CC-38848

Test plan

  • tsc --noEmit + Prettier green locally.
  • Cypress CI on this branch: the attachment-storefront spec passes without exhausting retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant