CC-38848 Drain publish queue while waiting for deleted attachments to clear#367
Draft
stereomon wants to merge 2 commits into
Draft
CC-38848 Drain publish queue while waiting for deleted attachments to clear#367stereomon wants to merge 2 commits into
stereomon wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
product-attachment-storefront.cy.ts"…cannot see attachments after they are deleted in backoffice" flakes run-to-run on master compat CI. Root cause is test-infra, not product code: the delete's publish→sync is a multi-stage queue chain, andreloadUntilGonereloaded the PDP but never re-drained the queue between reloads (unlikereloadUntilFound), so a lagging sync message never landed and the list never disappeared ("exhausted retries").Fix:
reloadUntilGonenow takes acommandsarg (mirroringreloadUntilFound) and re-runs the queue worker on every reload, so the wait keeps draining until storage actually reflects the delete.Jira: https://spryker.atlassian.net/browse/CC-38848
Test plan
tsc --noEmit+ Prettier green locally.