Skip to content

Remove reqwest/tower from default OTLP graph#1248

Merged
lovasoa merged 6 commits intomainfrom
chore/remove-reqwest-tower-from-otel
Mar 16, 2026
Merged

Remove reqwest/tower from default OTLP graph#1248
lovasoa merged 6 commits intomainfrom
chore/remove-reqwest-tower-from-otel

Conversation

@lovasoa
Copy link
Collaborator

@lovasoa lovasoa commented Mar 15, 2026

Summary

  • disable opentelemetry-otlp default features and keep only OTLP HTTP + metrics with hyper client
  • remove reqwest and tower from the default-feature dependency graph
  • switch OTLP span/metric export processors to tokio async-runtime variants so hyper OTLP export works reliably

Validation

  • cargo fmt --all
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test uploads::test_file_upload_too_large
  • cargo tree --no-default-features -i reqwest (no match)
  • cargo tree --no-default-features -i tower (no match)

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa8d30b6e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 695b608c4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lovasoa lovasoa merged commit fda4af3 into main Mar 16, 2026
14 checks passed
@lovasoa lovasoa deleted the chore/remove-reqwest-tower-from-otel branch March 16, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant