Skip to content

Log HTTP responses with correct severity and include status reason #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovasoa merged 2 commits into from
Mar 17, 2026
+8 −4
Merged

Log HTTP responses with correct severity and include status reason #1251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cfc10d
Log non-2xx HTTP responses in request completion log
lovasoa Mar 16, 2026
553fa57
fix log message
lovasoa Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/webserver/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,13 +371,17 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder {
DefaultRootSpanBuilder::on_request_end(span, outcome);

// Emit a single log event per completed request so it appears in logs.
// Error responses (4xx/5xx) are already logged by our error handlers.
let _enter = span_ref.enter();
if let Ok(response) = outcome {
let status = response.response().status();
if status.is_success() || status.is_redirection() {
log::info!("{}", status.canonical_reason().unwrap_or("ok"));
}
let level = if status.is_server_error() {
log::Level::Error
} else if status.is_client_error() {
log::Level::Warn
} else {
log::Level::Info
};
log::log!(level, "{status}");
}
}
}
Expand Down
Loading