Skip to content

feat(ios): Remove check of iOS 16.4 Workaround feature flag. #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsillik merged 1 commit into from
Sep 8, 2025
Merged

feat(ios): Remove check of iOS 16.4 Workaround feature flag. #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Changed

- The iOS 16.4 first responder workaround no longer checks UserDefaults, the workaround is always applied.

### Misc

### Internal
Expand Down
13 changes: 0 additions & 13 deletions ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,19 +263,6 @@ extension ListView {
return super_function(self, selector)
}

/// In case this workaround goes wrong somehow, we'll write a go/feature controlled flag
/// into `UserDefaults` in POS, and then read it here. This will allow us to disable the workaround
/// remotely if needed.
///
/// Note: We are explicitly **not** making this a static value, so it can be changed across reads.
let workaroundEnabled = UserDefaults.standard.object(
forKey: "Listable.EnableIOS164FirstResponderWorkaround"
) as? NSNumber ?? NSNumber(booleanLiteral: true)

guard workaroundEnabled.boolValue == true else {
return super_function(self, selector)
}

guard Self.hasFirstResponderViewProperty else {
assertionFailure("UICollectionView no longer has an ivar named `_firstResponderView`.")
return super_function(self, selector)
Expand Down
Loading