Conversation
Fixed without a :compiler source split. The Kotlin 2.4.0-Beta1 breakage was in plugin registration and test wiring, not in version-specific compiler APIs. - In compiler/build.gradle I removed the autoservice compiler plugin, made -Xcontext-parameters conditional for pre-2.4 only, and replaced generated registrations with static ServiceLoader files under compiler/src/main/resources/META-INF/services. That avoids the FIR registrar ClassCastException on 2.4. - I added Metro version alias wiring in integration-tests/app/build.gradle, integration-tests/demo/build.gradle, integration-tests/lib/build.gradle, and stubs/build.gradle, mapping 2.4.0-Beta1 to Metro's supported 2.4.0-dev-2124. - I applied the same alias in the compiler test harness at compiler/src/test/kotlin/com/squareup/metro/extensions/services/ExtensionRegistrarConfigurator.kt, which fixes the remaining :compiler:test failures. Verification: ./gradlew test --quiet and ./gradlew test --quiet -P kotlin.version=2.4.0-Beta1 both pass. Metro 0.12.1 still emits its upstream unrecognized Kotlin version warning for 2.4.0-Beta1, but the build and test suite are green with the alias in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.