Fix: peekNumber rejects some numerals like 2^64 + "0"#2114
Merged
JakeWharton merged 1 commit intoJun 11, 2026
Conversation
…octal representations, does not account for long overflows. This results in valid numeric literals like "184467440737095516160" (2^64 + "0") being rejected in STRICT parsing mode. The easiest way to reproduce this is to serialize and deserialize a BigInteger with the value above. This is a minimal fix which adds an overflow check to the leading zero condition. This bug was inherited from Gson, see google/gson#3034.
Collaborator
|
Was this discovered in the wild? The problem is that I'm not sure there will ever be another release of Moshi... At this point I think I'm going to move the |
Contributor
Author
|
Thanks for the info! Yes, I ran into this in the wild. I have a workaround and can fork Moshi if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: the "leading zero" logic in peekNumber, which tries to reject octal representations, does not account for long overflows. This results in valid numeric literals like "184467440737095516160" (2^64 + "0") being rejected in STRICT parsing mode.
The easiest way to reproduce this is to serialize and deserialize a BigInteger with the value above.
This is a minimal fix which adds an overflow check to the leading zero condition.
This bug was inherited from Gson, see google/gson#3034. It affects 1.x as well.